Skip to content

Fix! - #50430

Merged
zucchini-nlp merged 3 commits into
huggingface:mainfrom
zucchini-nlp:fix-ci-one-more-time
Nov 6, 2026
Merged

Fix!#50430
zucchini-nlp merged 3 commits into
huggingface:mainfrom
zucchini-nlp:fix-ci-one-more-time

Conversation

@zucchini-nlp

@zucchini-nlp zucchini-nlp commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: phi4_multimodal, qianfan_ocr

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@zucchini-nlp

Copy link
Copy Markdown
Member Author

run-slow: phi4_multimodal, qianfan_ocr

Comment on lines -294 to +296
audio_bytes = requests.get(self.audio_url, stream=True).raw.data
samples = torchcodec.decoders.AudioDecoder(audio_bytes).get_all_samples()
self.audio, self.sampling_rate = samples.data, samples.sample_rate
self.sampling_rate = 16000
self.audio = load_audio(self.audio_url, sampling_rate=self.sampling_rate)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make_list_of_audio doesn't accept batched arrays (2D np/torch) and I dont want to "fix" it yet. IMO that is an ambiguous input - is that batched input or single multi-channel one. I believe it's the same issue with any model, not phi specific

Instead i fix it here to load using out utils

):
raise ValueError("`text` must be a string or list of strings.")

n_images_in_text = [sample.count(self.image_placeholder_token) for sample in text]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uses image_placeholder_token instead of image_token

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm maybe we could introduce an alias instead?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they also have an image_token but used for different purposes 😭

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crap lol

@zucchini-nlp
zucchini-nlp requested a review from vasqu November 6, 2026 10:58
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

CI (Nvidia + AMD)

Nvidia · ✅ No new failures 🎉👏 · ⚙️ Workflow · 📊 Dashboard

AMD · ❌ 3 tests with changed errors 😭 · ⚙️ Workflow · 📊 Dashboard

Failures (3 pre-existing)

    Pre-existing failures (still failing) — 3 total:

        Error changed (3):

        - qianfan_ocr:
            tests/models/qianfan_ocr/test_modeling_qianfan_ocr.py::QianfanOCRIntegrationTest::test_model_integration_batched_generate (❌ ⟹ ❌)
            tests/models/qianfan_ocr/test_modeling_qianfan_ocr.py::QianfanOCRIntegrationTest::test_model_integration_forward (❌ ⟹ ❌)
            tests/models/qianfan_ocr/test_modeling_qianfan_ocr.py::QianfanOCRIntegrationTest::test_model_integration_generate (❌ ⟹ ❌)

@vasqu vasqu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but thanks

):
raise ValueError("`text` must be a string or list of strings.")

n_images_in_text = [sample.count(self.image_placeholder_token) for sample in text]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm maybe we could introduce an alias instead?

@zucchini-nlp
zucchini-nlp added this pull request to the merge queue Nov 6, 2026
Merged via the queue into huggingface:main with commit c6329dd Nov 6, 2026
51 checks passed
@zucchini-nlp
zucchini-nlp deleted the fix-ci-one-more-time branch November 6, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants